Implementation of "IsPrime", "Factors", "NextPr", "PrevPr"#1632
Open
jcbenoist wants to merge 4 commits intoc3d:stablefrom
Open
Implementation of "IsPrime", "Factors", "NextPr", "PrevPr"#1632jcbenoist wants to merge 4 commits intoc3d:stablefrom
jcbenoist wants to merge 4 commits intoc3d:stablefrom
Conversation
Author
|
Tests OK (thanks Claude again). Next step is to add range check in functions. M127 seems a limit for available memory. And test that remultiplying factors gives original number. I have to know, too, how to check if this is db48x ou db50x, or to check available memory; to set different limits for each hardware? With reflexion, instead of a range check, is there a graceful detection of stack or RAM overflow to abort a command ? Raw implementation => SEGV in SIM (stack overflow) |
Author
|
I have enhanced the tests. M73 & M83 fails for unclear reasons, since manually testing them in sim is perfectly OK. Maybe for memory or CPU reasons in a test context ? I have good confidence with the algorithms now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of "IsPrime", "Factors", "NextPr", "PrevPr". Tested on sim. I admit the core code is mostly generated by Claude Opus 4.6. I've done the integration to db48. If this PR is accepted, I'll do a test and will update the help files. I want to know first if this code have a chance to be integrated.
Hold on.. I'll develop tests right now, I have some suspiscions. Meanwhile, you can do comments or observations.
No, all seems OK. I'll publish tests soon.