-
Notifications
You must be signed in to change notification settings - Fork 22
fix language in 2.1 specification #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brianthered
wants to merge
1
commit into
c2pa-org:main
Choose a base branch
from
Brianthered:2.1-Specification-Section3-Edit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ node_modules/* | |
| package-lock.json | ||
| alex-out.txt | ||
| links-out.txt | ||
| /.vscode | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1095,10 +1095,10 @@ <h2 id="_versioning"><a class="anchor" href="#_versioning"></a>5. Versioning</h2 | |
| <div class="sect2"> | ||
| <h3 id="_compatibility"><a class="anchor" href="#_compatibility"></a>5.1. Compatibility</h3> | ||
| <div class="paragraph"> | ||
| <p>As the Content Credentials specification has evolved, constructs such as box labels, assertions (and their fields), claims and time-stamps have also evolved. New assertions have been added, and some existing assertions and the claim have newer versions with additional fields. In addition, some constructs have been deprecated. In this specification, when a construct is marked as deprecated, that means that a claim generator shall not write that construct (or value), but that a validator should read it.</p> | ||
| <p>As the Content Credentials specification has evolved, constructs such as box labels, assertions (and their fields), claims and time-stamps have also evolved. New assertions have been added, and some existing assertions and claims have newer versions with additional fields. In addition, some constructs have been deprecated. In this specification, when a construct is marked as deprecated, that means that a claim generator shall not write that construct (or value), but that a validator should read it.</p> | ||
| </div> | ||
| <div class="paragraph"> | ||
| <p>To facilitate interoperability between claim generators and validators, a claim generator declares which version of the specification it is using to generate the claim. When a claim generator declares that it is using a version of the specification, it is declaring that the active manifest of the asset is produced in accordance with that version of the specification and thus does not contain any deprecated constructs listed under that version of the specification in <a href="#deprecated_constructs_table">Table 19, “Deprecated Constructs”</a> of <a href="#versioning_annex">Appendix C, <em>Considerations for Deprecation</em></a>.</p> | ||
| <p>To facilitate interoperability between claim generators and validators, a claim generator declares which version of the specification it is using to generate the claim. When a claim generator declares that it is using a version of the specification, it is declaring that the active manifest of the asset is produced in accordance with that version of the specification and thus does not contain any deprecated constructs listed under that version of the specification in <a href="#deprecated_constructs_table">Table 19, “Deprecated Constructs”</a> of <a href="#versioning_annex">Appendix C, <em>Considerations for Deprecation</em></a>.</p> | ||
| </div> | ||
| <div class="admonitionblock note"> | ||
| <table> | ||
|
|
@@ -1331,7 +1331,7 @@ <h4 id="_2_1_september_2024"><a class="anchor" href="#_2_1_september_2024"></a>5 | |
| <div class="sect3"> | ||
| <h4 id="_2_0_january_2024"><a class="anchor" href="#_2_0_january_2024"></a>5.2.2. 2.0 - January 2024</h4> | ||
| <div class="paragraph"> | ||
| <p>This version represents a significant departure from previous versions. It reduces the use of the term "actor", which no longer represents humans and organisations. In addition to validator-configured trust lists, it also introduces a new default trust list, the "C2PA Trust List", which is intended to cover certificates issued to hardware and software. This philosophical change led to the following functional changes in the specification:</p> | ||
| <p>This version represents a significant departure from previous versions. It reduces the use of the term "actor", which no longer represents humans and organizations. In addition to validator-configured trust lists, it also introduces a new default trust list, the "C2PA Trust List", which is intended to cover certificates issued to hardware and software. This philosophical change led to the following functional changes in the specification:</p> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use Int'l English (which uses |
||
| </div> | ||
| <div class="ulist"> | ||
| <ul> | ||
|
|
@@ -5044,10 +5044,10 @@ <h4 id="_decompression"><a class="anchor" href="#_decompression"></a>15.5.4. Dec | |
| <div class="sect3"> | ||
| <h4 id="_validating_a_match"><a class="anchor" href="#_validating_a_match"></a>15.5.5. Validating a Match</h4> | ||
| <div class="paragraph"> | ||
| <p>A validator may wish to validate that the located C2PA Manifest Store is indeed the one associated with asset.</p> | ||
| <p>A validator may wish to validate that the located C2PA Manifest Store is indeed the one associated with the asset.</p> | ||
| </div> | ||
| <div class="paragraph"> | ||
| <p>If the C2PA Manifest Store was located then the hard binding assertion present in its active manifest shall be used to validate that it is the matching manifest and whether the asset has been modified without manifest updates. If the hard binding does not match, it is unknown if that is because of (a) modification of the asset or (b) the wrong C2PA Manifest Store was located. Accordingly, the validator shall treat this as a non-matching hard binding and reject the manifest with a failure code of <code>assertion.dataHash.mismatch</code> if a data hash assertion is used, <code>assertion.boxesHash.mismatch</code> if a general boxes hash assertion is used, <code>assertion.collectionHash.mismatch</code> if a collection data hash assertion is used, or <code>assertion.bmffHash.mismatch</code> if a BMFF hash assertion is used.</p> | ||
| <p>If the C2PA Manifest Store was located, the hard binding assertion present in its active manifest shall be used to validate that the C2PA Manifest Store is the matching manifest. Additionally, the validator will check whether the asset has been modified without manifest updates. If the hard binding does not match, it is unknown if that is because of (a) modification of the asset or (b) the wrong C2PA Manifest Store was located. Accordingly, the validator shall treat this as a non-matching hard binding and reject the manifest with a failure code of <code>assertion.dataHash.mismatch</code> if a data hash assertion is used, <code>assertion.boxesHash.mismatch</code> if a general boxes hash assertion is used, <code>assertion.collectionHash.mismatch</code> if a collection data hash assertion is used, or <code>assertion.bmffHash.mismatch</code> if a BMFF hash assertion is used.</p> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This proposed change is not technically correct. |
||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only ever a single claim in any C2PA Manifest.