Skip to content

fix(SoundVolume): addVolumeListener callback have same behaviour #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tt-driver-apps wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(SoundVolume): addVolumeListener callback have same behaviour #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ios/RTCSystemSetting.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,18 @@ +(BOOL)requiresMainQueueSetup{
}

RCT_EXPORT_METHOD(setVolume:(float)val config:(NSDictionary *)config){
[self stopObserving];

dispatch_sync(dispatch_get_main_queue(), ^{
id showUI = [config objectForKey:@"showUI"];
[self showVolumeUI:(showUI != nil && [showUI boolValue])];
volumeSlider.value = val;

__weak RCTSystemSetting *weakSelf = self;
[[NSNotificationCenter defaultCenter] addObserverForName:@"AVSystemController_SystemVolumeDidChangeNotification" object:nil queue:nil usingBlock:^(NSNotification * _Nonnull note) {
__strong RCTSystemSetting *strongSelf = weakSelf;
[strongSelf startObserving];
}];
});
}

Expand Down