Realign shrinker tests #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jmid
force-pushed
the
realign-shrinker-tests
branch
from
608ecaf to
68cda7e
Compare
jmid
force-pushed
the
realign-shrinker-tests
branch
from
68cda7e to
7fcebd2
Compare
Collaborator
Author
|
Rebased on |
Collaborator
Author
|
7 successful CI runs across Ubuntu, macOS and Windows before we hit a web-server failure causing the rest to be cancelled. I'll therefore go ahead and merge. Another vote for #276 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little PR realigns the
Shrinktests to reenable the shrinker benchmark from #177, meaning that the tests should be listed in the same order, and agree on theirnames.While adjusting the title of the QCheck2 test, I realized it was testing for a different value than the QCheck(1) test (comparing apples to oranges) so I fixed that.
This whole setup is admittedly fragile, but I'm not bothered enough to fix it ATM.