Skip to content

Add regression tests for qualified type #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-cube merged 2 commits into from
Dec 3, 2021
Merged

Add regression tests for qualified type #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ab91eb
Add regression tests for qualified type
bobot Dec 1, 2021
fac2c39
Fix constructor instead of ident
bobot Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ppx_deriving_qcheck/ppx_deriving_qcheck.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ let gen ~loc ?(env = TypeGen.empty) lg =
match lg with
| Lident s ->
Option.value ~default:(name s |> A.evar) @@ TypeGen.find_opt s env
| Ldot (lg, s) -> A.(pexp_construct (Located.mk @@ Ldot (lg, name s)) None)
| Ldot (lg, s) -> A.(pexp_ident (Located.mk @@ Ldot (lg, name s)))
| Lapply (_, _) -> raise (Invalid_argument "gen received an Lapply")

let frequency ~loc l = [%expr QCheck.Gen.frequency [%e l]]
Expand Down
7 changes: 7 additions & 0 deletions test/ppx_deriving_qcheck/deriver/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
(test
(name test)
(modules test)
(libraries alcotest ppxlib ppx_deriving_qcheck qcheck)
(preprocess (pps ppxlib.metaquot)))

(test
(name test_qualified_names)
(modules test_qualified_names)
(libraries qcheck)
(preprocess (pps ppx_deriving_qcheck)))
7 changes: 7 additions & 0 deletions test/ppx_deriving_qcheck/deriver/test_qualified_names.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module Q = struct
type t = int
[@@deriving qcheck]
end

type t = Q.t
[@@deriving qcheck]