Allow undef return value for dehydrated::file function#43
Merged
bzed merged 1 commit intobzed:masterfrom Jun 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
While debugging another issue, I came a cross the following evaluation error in
dehydrated::file:While not being the cause of my original issue, this evaluation error prevented me from getting further debugging information, which I needed to fix my problem.
This Pull Request (PR) fixes the following issues
This pull request fixes the return type of
dehydrated::fileto also acceptundefas return value, which is returned in case of an error.I believe this is the intended behavior, since it matches the remaining code, handling
undefin case of an error.