- PR for fixing the default {} issue #108#110
Open
danielspaniel wants to merge 1 commit intobyroot:masterfrom
Open
- PR for fixing the default {} issue #108#110danielspaniel wants to merge 1 commit intobyroot:masterfrom
danielspaniel wants to merge 1 commit intobyroot:masterfrom
Conversation
Author
|
@byroot this is one idea of how to fix this issue. if you have others, let me know .. open to suggestions and other ideas |
Owner
|
I haven't looked at the code in details, but there's tons of CI failures. |
danielspaniel
force-pushed
the
issue#108-fix
branch
from
76275db to
41cd4bf
Compare
Author
|
tests fixed I think .. changed back the sqlite version |
now {} is serialized to db when the default value is {} instead of nil
danielspaniel
force-pushed
the
issue#108-fix
branch
from
41cd4bf to
2271002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now {} is serialized to db when the default value is {} instead of nil