fix rounding in rainbow()#120
Open
landfillbaby wants to merge 2 commits intobusyloop:masterfrom
landfillbaby:patch-1
Open
fix rounding in rainbow()#120landfillbaby wants to merge 2 commits intobusyloop:masterfrom landfillbaby:patch-1
landfillbaby wants to merge 2 commits intobusyloop:masterfrom
landfillbaby:patch-1
Conversation
this is my first ruby code!
Contributor
|
essentially, this adds the missing 256th color? OH! NO! what a terrible mistake i made. It doesnt add anything but the (very small) possibility of enfing up generating Im just having fun with you, hahhàaha... no harm intended. Felt like throwing some bad humor while i ping this Oh, also... when you say "hope it works" - does it mean you havnt tried? |
|
BTW i think you guys should probably fix this issue- its been open for 2 years now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is my first ruby code! i hope it works!
this way the colours are a sine wave from 0-255, rounded properly :)
the current code is 1-255