build: collection of clippy fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the prefixes of the functions that encode and decode static integers via the format type. Clippy otherwise warns about `to_*()` not using `self` as by-value type. It also makes sense to avoid the known `to_*()` prefix, even though it kinda fits. Signed-off-by: David Rheinsberg <david@readahead.eu>
Clippy warns about usage of \0 if followed by 2 more digits. Given that outside of obscue TTY ASCII mappings no-one ever uses octal escapes, lets just silence the lint rather than significantly worsening readability by using `\x00`. Signed-off-by: David Rheinsberg <david@readahead.eu>
Silence the too-many-arguments lint on a code-generation helper. The purpose here is to put all arguments into a single call, so this is fine. Signed-off-by: David Rheinsberg <david@readahead.eu>
Fix the format of the safety comment to use a proper header. Signed-off-by: David Rheinsberg <david@readahead.eu>
Apply a selection of clippy lints, and silence other lints that we do not want to apply. Signed-off-by: David Rheinsberg <david@readahead.eu>
Rather than copying lints in each package, provide them via Cargo.toml. This requires extending `cargo-query` to parse lints. While at it, replace the shell script with a proper python script. Signed-off-by: David Rheinsberg <david@readahead.eu>
Rather than just running rustc lints, run clippy in CI. Signed-off-by: David Rheinsberg <david@readahead.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of fixes reported by clippy, plus adjustments to the build system to finally get clippy working in our CI setup with dual builds.