build: collection of minor cleanups #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 1.91 the strict arithmetic functions got stabilized, and we use them all over the place already. Update the documentation to reflect that. We also make use of a lot of const-fn in the new dbus modules, and those also require newer rustc. Lets settle on 1.91 for now, and ensure that CI verifies builds with it in a follow up. Signed-off-by: David Rheinsberg <david@readahead.eu>
Pass the new `--check-cfg` flag for all used cfg-options, so rustc can start checking all uses of `#[cfg]`. Signed-off-by: David Rheinsberg <david@readahead.eu>
Rather than relying on the obscure default feature for optional dependencies, provide `libc` as an explicit feature. Signed-off-by: David Rheinsberg <david@readahead.eu>
Add a new lint section and ensure that all workspace projects inherit the lints properly. Signed-off-by: David Rheinsberg <david@readahead.eu>
Rather than making the polonius verification a feature, use a plain configuration option. This is more cumbersome to use, but that is also the point. Users should not be required to make use of it. The advantage is that `--all-features` can now be used again, and does not require using nightly compilers and enabling polonius. Signed-off-by: David Rheinsberg <david@readahead.eu>
Run one build using polonius and explicitly make use of it in our code-base to verify unsafe code that needs workarounds without polonius. Signed-off-by: David Rheinsberg <david@readahead.eu>
With `polonius` moved to a proper cfg, we can enable all features again. Signed-off-by: David Rheinsberg <david@readahead.eu>
The legacy polonius implementation is not updated anymore, and thus produces some ICEs with libc builds. Use polonius=next, which is what we want, anyway. Signed-off-by: David Rheinsberg <david@readahead.eu>
Add another build that uses the MSRV to verify that we do not use newer features than announced. Signed-off-by: David Rheinsberg <david@readahead.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of minor cleanups and improvements. See each commit message for details.