Conversation
|
I'm currently stuck on finding a good way to make this change compatible with JSON exporting/importing. Currently I'm injecting metadata to exported JSON as the Maybe it'd be better to return a tuple from |
| end) | ||
|
|
||
| it("should not contain empty datastore names", function() | ||
| itSKIP("should not contain empty datastore names", function() -- NOTE: Test failing, skipped |
There was a problem hiding this comment.
Interesting, are all these tests failing because of the added changes, or were they failing before?
There was a problem hiding this comment.
They were failing before making any changes. I might not have set up my fork correctly (maybe I messed up something w/submodules?)
There was a problem hiding this comment.
I just did a fresh clone of the repository on my end, submodule initialized properly & everything, and the tests failed for me as well.
This PR implements DataStores v2 APIs. Resolves #22
Some tests are disabled in this branch as they were failing when I forked.
Changes:
MockDataStoreService:GetAsyncandMockDataStoreService:SetAsyncwith corresponding testsUtils.importPairsFromTableto inject metadataMockDataStoreService:ExportToJSONto inject metadata