Skip to content

Conversation

@pbusko
Copy link
Contributor

@pbusko pbusko commented Jul 3, 2024

Signed-off-by: Pavel Busko <pavel.busko@sap.com>
@pbusko pbusko force-pushed the add-run-flag-restorer branch from f91b109 to 664e7a0 Compare July 3, 2024 10:32
@natalieparellano natalieparellano changed the base branch from main to platform/0.14 July 3, 2024 14:10
Signed-off-by: Pavel Busko <pavel.busko@sap.com>
@pbusko pbusko force-pushed the add-run-flag-restorer branch from a4569c6 to 7f44395 Compare July 4, 2024 10:31
@pbusko pbusko requested a review from natalieparellano July 4, 2024 10:31
@natalieparellano natalieparellano added this to the Platform 0.14 milestone Jul 9, 2024
@natalieparellano natalieparellano merged commit 08ee76e into buildpacks:platform/0.14 Jul 9, 2024
jjbustamante added a commit to buildpacks/pack that referenced this pull request Jan 23, 2026
This implements the missing feature from Platform API 0.14 where the
restorer should accept a -run flag to enable read access validation
for run images selected by extensions during the restore phase.

When extensions switch the run image to one listed in run.toml, the
restorer needs to verify accessibility using the platform's
authentication context (CNB_REGISTRY_AUTH). This prevents builds from
proceeding with images the system cannot actually access.

Changes:
- Add -run flag to restorer when Platform API >= 0.14
- Write run.toml file via WriteRunToml operation
- Add tests verifying flag is present for Platform API >= 0.14
- Add tests verifying flag is absent for Platform API < 0.14

Fixes #2515

References:
- Spec PR: buildpacks/spec#408
- Lifecycle PR: buildpacks/lifecycle#1364

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jjbustamante added a commit to buildpacks/pack that referenced this pull request Jan 23, 2026
This implements the missing feature from Platform API 0.14 where the
restorer should accept a -run flag to enable read access validation
for run images selected by extensions during the restore phase.

When extensions switch the run image to one listed in run.toml, the
restorer needs to verify accessibility using the platform's
authentication context (CNB_REGISTRY_AUTH). This prevents builds from
proceeding with images the system cannot actually access.

Changes:
- Add -run flag to restorer when Platform API >= 0.14
- Write run.toml file via WriteRunToml operation
- Add tests verifying flag is present for Platform API >= 0.14
- Add tests verifying flag is absent for Platform API < 0.14

Fixes #2515

References:
- Spec PR: buildpacks/spec#408
- Lifecycle PR: buildpacks/lifecycle#1364

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants