Fix auth by wrapping keychain in a ResolvedKeychain #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
btw there is already v4 of codecov/codecov-action that is failing |
jjbustamante
approved these changes
Apr 9, 2024
Member
jjbustamante
left a comment
jjbustamante
left a comment
There was a problem hiding this comment.
I saw this error Yesterday with @matejvasek, this change looks good to me according to our analysis. NewResolvedKeychain was removed in the previous commit and need to be restore
jabrown85
approved these changes
Apr 10, 2024
Member
Author
|
Looks like the Codecov token is now required, this should be fixed in #1282 then we can merge this one |
Contributor
|
You should be able to rebase now @natalieparellano |
Prior to #1315, all keychains passed to NewMultiKeychain were resolved keychains, which prevented the credentials from becoming inaccessible after the lifecycle dropped privileges. Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/keychain
branch
from
2d40bed to
2670257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #1315, all keychains passed to NewMultiKeychain were resolved keychains, which prevented the credentials from becoming inaccessible after the lifecycle dropped privileges.