[WIP] Unenforced indices #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the main key functionality into a trait, and makes Key<...> the default key used by Slots. This will later enable non-enforced keys, and could be extended to other forms of authentication of keys.
Owner
|
Marked as draft before I accidentally merge this |
Owner
|
I think #10 would be a nicer solution |
Contributor
Author
|
Better than this approach at any rate, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow having both the regular (never-panicking unless #4 is triggered) kind of slots instances and instances that use a different kind of key (currently an unwrapped usize, could just as well get a more scary name and
From<>/Into<>implementations) where keys are not guaranteed to be usable.This is work in progress and not meant as an immediate fix, rather as an illustration for the discussion at #2.