Open
Conversation
MicaelRodrigues
force-pushed
the
typescript
branch
2 times, most recently
from
f25ca8d to
5fe830a
Compare
bsonntag
reviewed
Feb 28, 2022
package.json
Outdated
| "lint": "eslint . && prettier --check \"./**/*.{js,json}\"", | ||
| "type-check": "tsc --noEmit", | ||
| "type-check:watch": "npm run type-check -- --watch", | ||
| "build": "npm run build:types && npm run build:js", |
Owner
There was a problem hiding this comment.
There is no build:types script. Did you forget to add it?
Author
There was a problem hiding this comment.
Sorry, i meant to run the type-check script. Fixed.
MicaelRodrigues
force-pushed
the
typescript
branch
2 times, most recently
from
35435cb to
b9d36a3
Compare
added 2 commits
March 5, 2022 11:34
MicaelRodrigues
force-pushed
the
typescript
branch
from
b9d36a3 to
81ae36a
Compare
MicaelRodrigues
force-pushed
the
typescript
branch
from
81ae36a to
c950bb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds type-checking to the module, by using typescript integrated with babel configuration for compilation.