-
Notifications
You must be signed in to change notification settings - Fork 22
Feat help center routing #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@AlokPy1484 is attempting to deploy a commit to the Akash Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Please ensure that the review focuses only on your changes and that these changes align with the existing codebase structure. |
I have made changes in Footer.tsx file and added a new FrequentlyAskedQuestions.tsx file. Apart from this a am using Accordion Component of ShadCN UI library for which I had install ShadCN in project. I believe these changes are in sync with current codebase structure. Is there any part of code/file in particular that you would like me to change/look into the it would be helpful if you can point that file/code. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
But we already have a full Tailwind CSS codebase. Do you think it's necessary to use Shadcn UI for just one page? It would break code consistency, and I suggest using Tailwind CSS to maintain the current structure. |
Ok I undestand your concern. But just to clarify I am still using Tailwind CSS for all the styling work on the FrequentlyAskedQuestion.tsx page. ShadCN is being used only to get an accordion component. By importing ShadCN in our project, It downloads a Accordion.tsx file and add few custom styling in global.css file and does not affect any other part of the code. ShadCN have a vast set of components which we can use in our project for any future enhancements. |
|
Apart from this I have visually inspected the project after changes were made by going to PR deployed URL at https://web-git-fork-alokpy1484-f-195b35-akash-kumars-projects-ad425afb.vercel.app and I was not able to figure out any unexpected behaviour. |
|
Using shadcn just for an accordion might be unnecessary unless we’re planning a larger codebase revamp. For now, a custom accordion should work well. @AlokPy1484 |
6e90e74 to
f847ff1
Compare
f847ff1 to
513d07f
Compare
|
@akash-kumar-dev kindly check it now. I have used a custom Accordion component in place of ShadCN |
This PR aims to close issue #16. It intoduces a FAQ page route to answer few of the commanly raised query of BrowserPing's users.
🚀 Changes Made
🧠 How It Works
🧪 Testing
✅ Tested by Cloning the branch and running
and then visiting localhost:3000
Website was working as expected and {URL}/faq route was working on clicking on "Help Center" in footer.
✅ Ensured normal navigation flow after FAQ completion.
✅ Checked visual consistency of guide page