Conversation
WalkthroughPackage manifest updates: async-function-execution removes the nlohmann-json dependency and is bumped to v1.0.0; fleet-protocol-cpp adds aeron and async-function-execution dependencies, replaces a DockerMatrix image entry, and is bumped to v1.2.0. Minor Dockerfile adjustments for cmake installation and aliasing; DockerMatrix for fleet-protocol-interface adds ubuntu2504. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docker/fleet-os-3/Dockerfile`:
- Around line 64-65: The RUN that appends an alias to /root/.bashrc will not
affect non-interactive build shells; replace the alias approach by either
creating a real symlink or wrapper for cmake at /usr/local/bin/cmake (so it
overrides the toolchain binary) or ensure /usr/local/bin is prepended to PATH
during build/runtime (e.g., export PATH with /usr/local/bin first) instead of
relying on the alias; update the Dockerfile step that currently runs echo "alias
cmake=..." so it implements one of these deterministic overrides for the cmake
binary.
Summary by CodeRabbit