Skip to content

change async execution versions#13

Open
koudis wants to merge 2 commits intomasterfrom
BAF-1183/aeron_add
Open

change async execution versions#13
koudis wants to merge 2 commits intomasterfrom
BAF-1183/aeron_add

Conversation

@koudis
Copy link
Member

@koudis koudis commented Jan 19, 2026

Summary by CodeRabbit

  • Chores
    • async-function-execution released at v1.0.0 with a streamlined dependency configuration.
    • fleet-protocol-cpp released at v1.2.0 and now depends on additional internal packages.
    • CI/build environments updated to add Ubuntu 25.04 images and align toolchain/cmake behavior for compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

Package manifest updates: async-function-execution removes the nlohmann-json dependency and is bumped to v1.0.0; fleet-protocol-cpp adds aeron and async-function-execution dependencies, replaces a DockerMatrix image entry, and is bumped to v1.2.0. Minor Dockerfile adjustments for cmake installation and aliasing; DockerMatrix for fleet-protocol-interface adds ubuntu2504.

Changes

Cohort / File(s) Summary
async-function-execution manifests
package/async-function-execution/async-function-execution_debug.json, package/async-function-execution/async-function-execution_release.json
Removed nlohmann-json from DependsOn; Git.Revision and Package.VersionTag bumped from v0.1.0v1.0.0.
fleet-protocol-cpp manifests
package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json, package/fleet-protocol-cpp/fleet_protocol_cpp_release.json
Added aeron and async-function-execution to DependsOn; Git.Revision and Package.VersionTag bumped v1.1.1v1.2.0; replaced DockerMatrix.ImageNames entry fedora40ubuntu2504.
fleet-protocol-interface manifests
package/fleet-protocol-interface/fleet_protocol_debug.json, package/fleet-protocol-interface/fleet_protocol_release.json
Added ubuntu2504 to DockerMatrix.ImageNames.
Docker image/tooling
docker/fleet-os-3/Dockerfile
Updated cmake install step to remove downloaded script and appended an alias (alias cmake='/usr/local/bin/cmake') into /root/.bashrc via an added RUN.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • koudis
🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (8 files):

⚔️ config/README.md (content)
⚔️ docker/fleet-os-3/Dockerfile (content)
⚔️ package/async-function-execution/async-function-execution_debug.json (content)
⚔️ package/async-function-execution/async-function-execution_release.json (content)
⚔️ package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json (content)
⚔️ package/fleet-protocol-cpp/fleet_protocol_cpp_release.json (content)
⚔️ package/fleet-protocol-interface/fleet_protocol_debug.json (content)
⚔️ package/fleet-protocol-interface/fleet_protocol_release.json (content)

These conflicts must be resolved before merging into master.
Resolve conflicts locally and push changes to this branch.
Title check ❓ Inconclusive The title 'change async execution versions' is partially related to the changeset. While version bumps occur in async-function-execution files, the PR also includes significant changes to fleet-protocol-cpp (dependency additions, version updates), fleet-protocol-interface (Docker matrix updates), and Dockerfile modifications. The title focuses narrowly on async execution versions and misses the broader scope of changes. Consider revising the title to reflect the full scope of changes, such as 'Upgrade dependencies and versions for async-function-execution and fleet-protocol-cpp' or providing a title that encompasses all modified packages and the cmake configuration adjustment.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BAF-1183/aeron_add
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch BAF-1183/aeron_add
  • Create stacked PR with resolved conflicts
  • Post resolved changes as copyable diffs in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docker/fleet-os-3/Dockerfile`:
- Around line 64-65: The RUN that appends an alias to /root/.bashrc will not
affect non-interactive build shells; replace the alias approach by either
creating a real symlink or wrapper for cmake at /usr/local/bin/cmake (so it
overrides the toolchain binary) or ensure /usr/local/bin is prepended to PATH
during build/runtime (e.g., export PATH with /usr/local/bin first) instead of
relying on the alias; update the Dockerfile step that currently runs echo "alias
cmake=..." so it implements one of these deterministic overrides for the cmake
binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments