Add a method to collect the DNS names from a certificate#91
Add a method to collect the DNS names from a certificate#91seanmonstar wants to merge 1 commit intobriansmith:mainfrom
Conversation
|
r? @briansmith |
|
Looks like CI failures are spurious |
|
Why skip wildcard names? This is the kind of information I'd like to gather from a certificate. Or is there another way to get it? |
I support adding support for wildcards as long as non-wildcard and wildcard names are explicitly distinguished in the type system, e.g. adding a |
|
Closing this in favor of PR #103. PLMK if this was the wrong thing to do. Note: I renamed the "master" branch to "main". Sorry for the inconvenience. This PR has had its base branch updated to "main" but you'll need to deal with the change in your local repo yourself. |
This continues on the work from #65, and adds what seems to have been missing per the review:
invalid_subject_alternative_names. Instead of returning aBadDERerror because one name wasn't a validDNSName, those names are just skipped instead.Closes #64