Added an unrecognized_extensions hash to the Cert struct#259
Open
dreemkiller wants to merge 2 commits intobriansmith:mainfrom
Open
Added an unrecognized_extensions hash to the Cert struct#259dreemkiller wants to merge 2 commits intobriansmith:mainfrom
unrecognized_extensions hash to the Cert struct#259dreemkiller wants to merge 2 commits intobriansmith:mainfrom
Conversation
Author
|
I've found a way to make it cleaner in the second commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to #258 .
When the feature
stdis enabled, adds anunrecognized_extensionsmember to theCertstruct in the form of aHashMapModifies the
remember_extenstionsfunction to place the data from any unrecognized extension into thatHashMap, with the extension ID as the key.Due to apparent limitations of rust, I was unable to find a way to use the existing
oidmacro for the match expressions. (hence the addition of[allow(unused_macros)]for theoidmacro.Suggestions on how this could be made cleaner are appreciated.