Conversation
stepancheg
force-pushed
the
cli
branch
2 times, most recently
from
bb29bf0 to
3ed5630
Compare
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 71.70% 71.70%
=======================================
Files 17 17
Lines 1403 1403
=======================================
Hits 1006 1006
Misses 397 397
Continue to review full report at Codecov.
|
Contributor
Author
|
Updated the PR with a subcommand to verify server certificate. |
briansmith
reviewed
Feb 17, 2021
briansmith
reviewed
Feb 17, 2021
briansmith
reviewed
Feb 17, 2021
stepancheg
added a commit
to stepancheg/webpki
that referenced
this pull request
Feb 17, 2021
Follow-up to briansmith#187. I agree to license my contributions to each file under the terms given at the top of each file I changed.
Contributor
Author
|
Done. This is rebased on top #192. |
briansmith
reviewed
Feb 17, 2021
src/signed_data.rs
Outdated
| /// All signature algorithms supported by the webpki crate. | ||
| /// | ||
| /// Note the list depends on whether `alloc` feature is on or off. | ||
| pub static ALL_SIGNATURE_ALGORITHMS: &[&SignatureAlgorithm] = &[ |
Owner
There was a problem hiding this comment.
Sorry, I know I asked you to move this into the library but that was a mistake on my part. Please move it back to where you had it before and add a comment to this:
// Keep in sync with ALL_SIGALGS in tests/integration.rs.
briansmith
reviewed
Feb 17, 2021
For now it has two subcommands:
* just parse end entity certificate
* verify server certificate
Is not meant to be public, does not provide a stable interface.
Useful mostly for debugging of WebPKI itself.
```
% cargo run -p webpki-bin -- print-cert ./tests/netflix/ca.der
...
target/debug/webpki: failed to parse a cert ./tests/netflix/ca.der: BadDER
```
```
% cargo run -p webpki-bin -- verify-server-cert \
--server-cert tests/netflix/ee.der \
--trusted-root tests/netflix/ca.der \
--intermediates tests/netflix/inter.der \
--time 1492441716
...
server certificate tests/netflix/ee.der is valid
```
I agree to license my contributions to each file under the terms
given at the top of each file I changed.
Contributor
Author
|
Reverted to the previous version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now it has two subcommands:
Is not meant to be public, does not provide a stable interface.
Useful mostly for debugging of WebPKI itself.