Support yaml configs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianebeyer
commented
Jun 7, 2018
|
|
||
| def install | ||
| args = std_cmake_args | ||
| # if build.with? "static-lib" |
Owner
Author
There was a problem hiding this comment.
Not sure osquery standard for this or how to ensure this flag gets set
zacbrown
requested changes
Jun 7, 2018
osquery/config/config.cpp
Outdated
| #include <osquery/registry.h> | ||
| #include <osquery/tables.h> | ||
|
|
||
| #include "yaml-cpp/yaml.h" |
Collaborator
There was a problem hiding this comment.
Did you mean to use <yaml-cpp/yaml.h> instead of "yaml-cpp/yaml.h". By convention - you use the angle brackets when it's part of the include path. You use the quotation marks when it's local to your own directory.
osquery/config/config.cpp
Outdated
| convertedJsonWriter.Bool(false); | ||
| } else { | ||
| if (node.Tag() != "!") { | ||
| const char* end = nodeVal.c_str() + nodeVal.length(); |
Collaborator
There was a problem hiding this comment.
Nit: probably a good place to use auto.
| } | ||
|
|
||
| // try parsing it as a long | ||
| auto i = strtoll(nodeVal.c_str(), &pos, 10); |
Collaborator
There was a problem hiding this comment.
Is it useful to support decimal annotated integers? (YAML Spec - section 2.4)
For example: +1234. I'm not sure if strtoll supports that or not.
|
|
||
| def install | ||
| args = std_cmake_args | ||
| # if build.with? "static-lib" |
Collaborator
There was a problem hiding this comment.
Did you mean to leave these comment lines in? Do they need to be uncommented?
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.