Improve lint target to check and fix Go version mismatches#36
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Improve lint target to check and fix Go version mismatches#36devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add version checking logic to detect golangci-lint Go version compatibility - Automatically reinstall golangci-lint with correct Go version if mismatch detected - Use GOTOOLCHAIN to ensure installation with project's required Go version - Prevents future 'Go language version used to build golangci-lint is lower than targeted Go version' errors Co-Authored-By: Alec Fong <alecsanf@usc.edu>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve lint target to check and fix Go version mismatches
Summary
Enhanced the
make linttarget to automatically detect and fix Go version mismatches between the installed golangci-lint and the project's Go version requirements. This prevents the error "Go language version used to build golangci-lint is lower than the targeted Go version" that was encountered when golangci-lint was built with an older Go version than specified in go.mod.The updated logic:
GOTOOLCHAINto ensure installation with the project's required Go versionReview & Testing Checklist for Human
3 items - needs careful testing due to shell complexity
make lintdetects and fixes the mismatchsort -Vcommand might behave differently)Recommended Test Plan
GOTOOLCHAIN=go1.23.0 go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8make lintand verify it detects the mismatch and reinstalls correctlymake lintagain to ensure it doesn't reinstall unnecessarilyNotes
sort -Vfor version comparison which should work on most systems but worth testing