PR for external review #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| node_modules | ||
| .DS_Store | ||
| .vscode | ||
| compensation.csv | ||
| compensation.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "extends": "solium:all", | ||
| "plugins": [ | ||
| "security" | ||
| ], | ||
| "rules": { | ||
| "quotes": [ | ||
| "error", | ||
| "double" | ||
| ], | ||
| "indentation": [ | ||
| "error", | ||
| 2 | ||
| ], | ||
| "arg-overflow": [ | ||
| "warning", | ||
| 3 | ||
| ], | ||
| "security/no-block-members": [ | ||
| "warning" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .DEFAULT_GOAL := all | ||
|
|
||
| CONTRACTS=BRDCrowdsaleAuthorizer BRDLockup BRDToken BRDCrowdsale | ||
| JSONS=build/%.json | ||
| SOLCOPTS=--combined-json abi,asm,ast,bin,bin-runtime,clone-bin,compact-format,devdoc,hashes,interface,metadata,opcodes,srcmap,srcmap-runtime,userdoc --pretty-json --optimize-runs 200 | ||
|
|
||
| build/flattened/%.sol: | ||
| truffle-flattener contracts/$*.sol > $@ | ||
|
|
||
| build/%.json: build/flattened/%.sol | ||
| solc $(SOLCOPTS) $^ > $@ | ||
|
|
||
| clean: | ||
| -rm build/*.json | ||
| -rm build/flattened/*.sol | ||
|
|
||
| all: $(patsubst %,$(JSONS), $(CONTRACTS)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # smart-contracts | ||
|
|
||
| This is the repository for the Bread Token (BRD) Crowdsale and ERC20 smart contracts. | ||
|
|
||
| ### Getting started | ||
|
|
||
| We use Truffle and OpenZeppelin for development. The main smart contracts (BRDToken and | ||
|
There was a problem hiding this comment. please create npm init .
npm install --save zeppelin-solidityafter execute it, commit |
||
| BRDCrowdsale) are based on OpenZeppelin's MintableToken and Crowdsale base contracts. | ||
|
|
||
| For development, we use ganache-cli using the default settings. | ||
|
|
||
| To test, start ganache-cli and run `truffle test` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you didn't add
/builddirectory here?I think should not commit any artifacts compiled from source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am including build so dependent repositories can use the generated code without requiring the whole solidity/truffle/npm toolchain. They can consume the JSON files directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea for include JSON file. but how about "flatten" code? it makes difficult to review code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's true, I can remove those. The reason they are included is they are necessary to verify the individual contracts on etherscan