fix breaking change in artifact handling v3 to v4 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
No problem — it cost me only a few minutes of work to test a release and then circle back to you with the error message — but you have saved me far more than a few minutes by volunteering to help with the build, so thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brandon-rhodes,
Attached the fix for the broken part in artefactory workflow. I did try to test is as far I could go (I made a release branch like yours to see if the workflow is running without problems. I could not check the upload itself, but the files are now present in dist folder. So it should run through now.
I also removed the upgrade pip installation as it does not remove the single warning in workflow. This happens during the python-setup workflow, which is imported.
Again sorry for the missing changes I forgot.
Michel