Skip to content

Conversation

@mworion
Copy link
Contributor

@mworion mworion commented Apr 25, 2025

Hi Brandon,

I do not want to bother you again with the CI build. I was still not satisfied about the GitHub build action solution at all. We got in addition #139 which prohibited the linux arch64 wheels. I decided to do a rework.
At the end, the workflow now has 100 lines less, and makes the next python release 3.14 done by just adding the string '3.14' in only 2 lines. Hopefully it is even more understandable.

The wheel setup / version and the way of offering the MacOS solutions changed, but should be OK in PyPI packet index.

Please review it at your convenience and please come back if changes are necessary.

This is the second attempt without any changes to the first one to check if Github runners fail structurally what could not see in my local dev environment (also with GitHub)

Michel

@brandon-rhodes brandon-rhodes merged commit 452833b into brandon-rhodes:master May 2, 2025
55 of 60 checks passed
@brandon-rhodes
Copy link
Owner

I do not want to bother you again with the CI build.

I am not bothered at all; thank you for this additional work, which, I agree, makes the CI steps easier to read and reason about.

I was still not satisfied about the GitHub build action solution at all. We got in addition #139 which prohibited the linux arch64 wheels. I decided to do a rework. At the end, the workflow now has 100 lines less, and makes the next python release 3.14 done by just adding the string '3.14' in only 2 lines. Hopefully it is even more understandable.

Reading through it, it does look easier to understand! Now that it's landed, I will wait until the next time I need to do a release; then, we'll see how it works, and whether everything makes it to PyPI successfully, and whether I really understand how it's working or not. 🙂

Thanks again for the contributions you make to the project!

@brandon-rhodes
Copy link
Owner

@mworion — I tried bumping the release branch to this new code, but the final step ran into an error:

https://github.com/brandon-rhodes/python-sgp4/actions/runs/14810389138/job/41584454227

Looking at the diff, I understand the old code, which did a separate download-artifact on each of the products that had been uploaded in the sections above it. But I'm not sure how the new code was supposed to work that just asked for a single named artifact? Is there a quick tweak that will get it working? Thanks for taking a look!

@mworion
Copy link
Contributor Author

mworion commented May 4, 2025

@brandon-rhodes: I'm so very sorry, I overlooked the breaking change from upload/download artifacts v3 -> v4. I mentioned that I started migrating to 3.13 , but I did it on v3. You already started with v4 (which was good) and I merged it on my side, but did not notice it.
So I corrected this. I will submit a new PR again the current master.
Michel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants