Conversation
Braintrust eval reportAutoevals (threads-1768759658)
|
ankrgyl
changed the title
colsondonohue
approved these changes
Jan 20, 2026
Comment on lines
+35
to
+46
| // Pattern to match thread variables in template syntax: {{thread, {{ thread, {%...thread, etc. | ||
| export const THREAD_VARIABLE_PATTERN = new RegExp( | ||
| `\\{[\\{%]\\s*(${THREAD_VARIABLE_NAMES.join("|")})`, | ||
| ); | ||
|
|
||
| /** | ||
| * Check if a template string might use thread-related template variables. | ||
| * This is a heuristic - looks for variable names after {{ or {% syntax. | ||
| */ | ||
| export function templateUsesThreadVariables(template: string): boolean { | ||
| return THREAD_VARIABLE_PATTERN.test(template); | ||
| } |
There was a problem hiding this comment.
edge case but if users set custom delimiters for whatever reason, this will fail:
https://github.com/mustache/spec/blob/master/specs/delimiters.yml
There was a problem hiding this comment.
I think this function shouldn't live in this repo long-term but it's fine for now.
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.