Add time-aware PID control method (fixes #35)#37
Open
chantakan wants to merge 1 commit intobraincore:masterfrom
Open
Add time-aware PID control method (fixes #35)#37chantakan wants to merge 1 commit intobraincore:masterfrom
chantakan wants to merge 1 commit intobraincore:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
next_control_output_with_dt(measurement, dt)method to handle time intervals properly in PID calculations, resolving the mathematical inaccuracies mentioned in #35.Problem Solved
Previously, the PID controller ignored actual time intervals (
dt) when calculating:error * kiinstead oferror * ki * dtmeasurement_change * kdinstead of(measurement_change / dt) * kdThis led to inconsistent behavior when:
Solution
New Method
next_control_output_with_dt(measurement: T, dt: T) -> ControlOutput<T>∫e(t)dt ≈ Σ(error × dt)de/dt = Δmeasurement / dtBackwards Compatibility
next_control_output()unchanged - now a thin wrapper calling new method withdt=1.0Testing
Added comprehensive test coverage:
integral_with_dt: Verifies proper time-weighted integrationderivative_with_dt: Verifies proper rate-of-change calculationbackwards_compatibility: Ensures existing behavior unchangedirregular_intervals: Tests real-world irregular timing scenarios