Update build job to check code for linting and formatting problems#29
Merged
Owez merged 2 commits intobraincore:masterfrom Apr 29, 2025
Merged
Update build job to check code for linting and formatting problems#29Owez merged 2 commits intobraincore:masterfrom
Owez merged 2 commits intobraincore:masterfrom
Conversation
Collaborator
|
I'll have a look over tomorrow :) been busy with work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some additional check to the build job in the Rust workflow
Motivation
Check and Clippy: These steps help protect us against well-known bad coding practices.
Format: Consistently formatted code makes for cleaner diffs and easier merging of code.
Autofix
These commands can be used to automatically fix some warnings and errors:
Changes
Add steps Check, Format, and Clippy to build job in Rust workflow
Rename build step from "Run tests" to "Test" to align with the other steps