Conversation
|
Let me know if you want me to remove the last commit |
mtilda
left a comment
There was a problem hiding this comment.
This will need to be rebased. We added set_integral_term in #27, which pulled a commit from #22.
I like the usage warning in your comment on set_integral_term.
I can see how get_integral_term could be a useful.
The tests you added look good, but they don't seem relevant to the methods you touched. I think they belong in a separate PR.
I rebased your branch locally, dropping the commit with the added tests, and pushed to a branch on my fork (commit).
a1bc1c2 to
525df5e
Compare
525df5e to
126e3d5
Compare
126e3d5 to
281b410
Compare
Done in #31
Thanks :) I cherry-picked that commit here. Feel free to merge this or your fork. Fine by me either way |
Add methods for getting/setting the integral term.
Add some more tests for integers