Conversation
|
@Evanraisul do you want this change or can we close it? You've imported and vendored a ton of stuff that's unnecessary for the change itself. The PR should be focused on just adding the feature you want. Thanks! |
|
I have updated the PR. You can review it now. |
|
I still see a bunch of unrelated changes and also looks like you may need to pull from upstream and rebase your branch? please carefully review what your commit looks like. sorry it's a litle odd looking still |
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
|
Sorry for the inconvenience. I think it is okay now. |
dormando
left a comment
There was a problem hiding this comment.
getting closer, thanks!
|
Resolved those stuffs. I think it is now ready for merge. |
|
Thanks! It might take a while before we review this, so please have patience. |
|
Tests are missing which is the biggest obvious thing. Before I ask that you add tests I want to review it and see if this is the right approach though. Thanks again! |
|
Okay, thanks. Will wait for your review. |
Signed-off-by: Muhammad Raisul Islam Evan evanraisul@gmail.com