Conversation
|
@bradfitz bump, although you do seem like a busy person.. 🤷♀️ |
|
This seems kinda nice but does need to be cleaned up. @MarcinKonowalczyk - this PR isn't super ancient so if you're up for addressing the review comment please do so. Else we'll look into it. |
|
ty for the poke! addressed and rebased on top of master. let me know what you think. ive changed the functionality to also something to specifically point out: i think the behaviour of VersionAll ought to be to return empty strings for unconnected instances. the rationale being that just because one instance is not connected ought not to stop one learning about other instances. having said that, there is an argument to be made for a simpler api: just one |
|
oh, also i;ve made a tiny clarification to doc of |
Exposed the 'version' call from ping as a method on Client