Open
Conversation
anjmao
reviewed
Jul 31, 2022
| // Check if the context is expired. | ||
| select { | ||
| default: | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
This looks a bit useless. At this point there is no network call yet. Dial happens below in c.dial. You want to extend dial with custom dialer, see https://pkg.go.dev/net#Dialer.DialContext
anjmao
reviewed
Jul 31, 2022
| // should be shared onto. | ||
| PickServer(key string) (net.Addr, error) | ||
| Each(func(net.Addr) error) error | ||
| PickServer(ctx context.Context, key string) (net.Addr, error) |
There was a problem hiding this comment.
- This is breaking change. I doubt it can be accepted.
- Wonder what is the use case to add context for these methods. You can have background goroutine which updates servers list if needed. Current implementation also indicates that context is not needed.
Collaborator
|
Note: #126 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR, which pretty much adds contexts to all exported methods, allows us to use that information not only in the main library component but also in custom server list, which then can be used for other stuff such as instrumentation for new relic, which was the original objective for which I forked the library.