Conversation
|
Will this change be merged? |
|
|
||
| func (c *Client) getFromAddr(addr net.Addr, keys []string, cb func(*Item)) error { | ||
| cmd := "gets" | ||
| if c.DisableCAS { |
There was a problem hiding this comment.
it looks like the meat of this PR is here... the DisableCAS bool that changes the command sent.
|
I like the concept of not using the CAS-y commands by default (didn't realize that was what was happening), however this PR has a lot of unrelated changes. I'm guessing the user is long gone, but if the PR could be reduced to just the intended change it would have a better chance. |
Oh I didn't realized that all the changes I've made after this PR were all synced here. In fact the initial commit was like what @mrauer did, see 1af313e, but the author didn't want to merge that and I then added some other features for my use cases. I'll close this PR to avoid more misunderstandings. |
#112 #111