Add github actions for deploying AWS ECS envs #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscripted
force-pushed
the
add-build-and-deploy-actions
branch
2 times, most recently
from
fb2ee46 to
65ac474
Compare
…nv-var-docs Initial outline of env variables found in project
…ongo-express-env-var Add db url to fix auth error (mongo-express on linux)
We tag our services with App and Env tags set on the service for cost allocation. It is especially useful in the AWS Cost Explorer console. The terraform definition of our services uses the propagate_tags setting when deploying the service, but our github actions do not by default do the same. This change adds the appropriate config to our github action to propagate tags the same way our terraform code does. Note that our cost alloctaions may be incorrectly categorizing charges in each of these repositories from our original merge of the gh action to now (March 28, 2025).
Problem: When ECS's circuit breaker mechanism rolls back a failing deploy, the deploy task github action will exit with a success code when infact the deployment was not successful. In order to identify unsuccessful service updates, we want the github action to fail. At time of writing, there is no option elicit this behavior from the aws-actions/amazon-ecs-deploy-task-definition@v2 action. Instead, we must check that the services current task definition is the one we attempted to roll out. See discussion in aws-actions/amazon-ecs-deploy-task-definition#191
willscripted
force-pushed
the
add-build-and-deploy-actions
branch
from
65ac474 to
535d91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.