feat: Add IfMatch and IfNoneMatch to ALLOWED_UPLOAD_ARGS#371
Open
amartani wants to merge 1 commit intoboto:developfrom
Open
feat: Add IfMatch and IfNoneMatch to ALLOWED_UPLOAD_ARGS#371amartani wants to merge 1 commit intoboto:developfrom
amartani wants to merge 1 commit intoboto:developfrom
Conversation
Adds `IfMatch` and `IfNoneMatch` to the list of allowed arguments for S3 uploads. This enables users to perform conditional uploads, such as preventing the overwrite of existing files by using `IfNoneMatch: "*"`. These parameters are not supported by the `CreateMultipartUpload` API call, so they are added to the blocklist for that specific operation to prevent validation errors. For multipart uploads, these parameters are passed to the `CompleteMultipartUpload` operation. Functional tests have been added for both single-part and multipart uploads to verify that the arguments are passed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
boto/boto3#4366
Description of changes:
Adds
IfMatchandIfNoneMatchto the list of allowed arguments for S3 uploads. This enables users to perform conditional uploads, such as preventing the overwrite of existing files by usingIfNoneMatch: "*".These parameters are not supported by the
CreateMultipartUploadAPI call, so they are added to the blocklist for that specific operation to prevent validation errors. For multipart uploads, these parameters are passed to theCompleteMultipartUploadoperation.Functional tests have been added for both single-part and multipart uploads to verify that the arguments are passed correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.