Fix CI cross-platform coverage and Windows CRT install/run failures#368
Merged
jonathan343 merged 6 commits intodevelopfrom Feb 5, 2026
Merged
Fix CI cross-platform coverage and Windows CRT install/run failures#368jonathan343 merged 6 commits intodevelopfrom
jonathan343 merged 6 commits intodevelopfrom
Conversation
SamRemis
approved these changes
Feb 5, 2026
Contributor
SamRemis
left a comment
There was a problem hiding this comment.
Great catch! Thanks, Jonathan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes CI truly run on all OS matrix entries, fixes Windows CRT test execution, and updates dev dependency pins to support newer Python/Windows environments. It also hardens the
BaseManagertest againstspawn/forkserverand restricted socket environments.Issues
Note
You can look through previous CI failures to see the exact failures I'm referring to.
ubuntu-latest, hiding platform-specific failures.shell=Trueand single quotes, causing:ERROR: Invalid requirement: "'dist\\s3transfer-0.16.0-py3-none-any.whl[crt]'".scripts/ci/run-crt-testsattempted to execute a Python script path directly, resulting in:'.../scripts/ci/run-tests'is not recognized as an internal or external command.spawn/forkserverbehavior causedAttributeError: Can't pickle local object '...PIDManager'.Solutions
shell=Truecommand strings in CI install scripts with argument lists andsys.executable -m pipto avoid Windows quoting issues.scripts/ci/run-testsviasys.executablein CRT CI to make it runnable on Windows.BaseManagertest forspawn/forkserverenvironments.BaseManagersignal-handler test when socket binding is not permitted.Testing
Important
Our GitHub CI only runs unit and functional tests. I made sure to run integration tests locally to ensure our releases won't break.
Without CRT:
With CRT:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.