Add streaming fileobj support to CRTTransferManager#277
Open
graebm wants to merge 7 commits intoboto:developfrom
Open
Add streaming fileobj support to CRTTransferManager#277graebm wants to merge 7 commits intoboto:developfrom
graebm wants to merge 7 commits intoboto:developfrom
Conversation
graebm
commented
Oct 18, 2023
Comment on lines
+163
to
+165
| ALLOWED_DOWNLOAD_ARGS = TransferManager.ALLOWED_DOWNLOAD_ARGS | ||
| ALLOWED_UPLOAD_ARGS = TransferManager.ALLOWED_UPLOAD_ARGS | ||
| ALLOWED_DELETE_ARGS = TransferManager.ALLOWED_DELETE_ARGS |
Contributor
Author
There was a problem hiding this comment.
Should I make a common base class for TransferManager and CRTTransferManager, where I can put stuff like these lists, and def _validate_all_known_args() and def _validate_if_bucket_supported()?
Or move these to be standalone lists/functions that both classes can use?
Or just copy/paste the functions, and reference the lists, like I'm doing here?
| call_args.extra_args["Body"] = call_args.fileobj | ||
|
|
||
| # We want the CRT S3Client to calculate checksums, not botocore. | ||
| # Default to CRC32. |
Contributor
Author
There was a problem hiding this comment.
This is different than the default TransferManager. With this change CRT is defaulting to CRC32 instead of Content-MD5. The CRT team got grumpy about how Content-MD5 currently works in our code and pushed me to do it this way, but we can still make Content-MD5 work if we need to.
This was referenced Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to CRTTransferManager:
ChecksumAlgorithmextra_argsThis relies on awscrt 0.19.4+
We'll need to update botocore's dependencies, before this can go in.