Skip to content

fix ExpectedBucketOwner argument mapping in head_object request durin… #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierre-muller wants to merge 1 commit into from
Closed

fix ExpectedBucketOwner argument mapping in head_object request durin… #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s3transfer/copies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class CopySubmissionTask(SubmissionTask):
'CopySourceSSECustomerAlgorithm': 'SSECustomerAlgorithm',
'CopySourceSSECustomerKeyMD5': 'SSECustomerKeyMD5',
'RequestPayer': 'RequestPayer',
'ExpectedBucketOwner': 'ExpectedBucketOwner',
'ExpectedSourceBucketOwner': 'ExpectedBucketOwner',
}

UPLOAD_PART_COPY_ARGS = [
Expand Down
2 changes: 2 additions & 0 deletions tests/functional/test_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ def test_copy_with_extra_args(self):

def test_copy_maps_extra_args_to_head_object(self):
self.extra_args['CopySourceSSECustomerAlgorithm'] = 'AES256'
self.extra_args['ExpectedBucketOwner'] = 'expectedbucketowner'

expected_head_params = {
'Bucket': 'mysourcebucket',
Expand All @@ -238,6 +239,7 @@ def test_copy_maps_extra_args_to_head_object(self):
'Key': self.key,
'CopySource': self.copy_source,
'CopySourceSSECustomerAlgorithm': 'AES256',
'ExpectedBucketOwner': 'expectedbucketowner',
}

self.add_head_object_response(expected_params=expected_head_params)
Expand Down