Allow custom s3 endpoint_url for use with boto3[crt]#4643
Open
masudio wants to merge 2 commits intoboto:developfrom
Open
Allow custom s3 endpoint_url for use with boto3[crt]#4643masudio wants to merge 2 commits intoboto:developfrom
masudio wants to merge 2 commits intoboto:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tl;dr is that boto3 has an option to use a faster underlying package called CRT (Common RunTime) for far greater S3 throughput. However, the integration with the underlying library is not complete for custom S3 endpoints (e.g. a company hosts an internal S3 API).
In addition, there is a bug this diff fixes where 'compare_identity' function doesn't treat "" and None as equal - this also prevents users from using CRT with boto3 with a custom endpoint_url.
More concretely, this particular diff does these pieces:
Testing
Added unit tests to cover the changes.