Depend on ros_environment where needed #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent commit f4e9860 ("Update dependency declarations for target_link_libraries", 2025-11-04) introduced dependency on ROS_DISTRO environment variable. Such an variable is only set if ros_environment package is available, but package.xml doesn't mention ros_environment as dependency. This can lead to the following error when building the package without ros_environment (e.g. when using the Nix package manager): -- Found pcl_conversions: 2.4.5 (/.../ros-humble-pcl-conversions-2.4.5-r2/share/pcl_conversions/cmake) ... [ 50%] Building CXX object CMakeFiles/off_highway_general_purpose_radar.dir/src/receiver.cpp.o /build/off_highway_sensor_drivers-release-release-humble-off_highway_general_purpose_radar-0.10.0-1/src/receiver.cpp:20:10: fatal error: pcl_conversions/pcl_conversions.h: No such file or directory 20 | #include "pcl_conversions/pcl_conversions.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This commit adds dependency on ros_environment to packages where it is needed. Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit f4e9860 ("Update dependency declarations for target_link_libraries", 2025-11-04) introduced dependency on
ROS_DISTROenvironment variable. Such an variable is only set ifros_environmentpackage is available, butpackage.xmldoesn't mentionros_environmentas dependency.This can lead to the following error when building the package without
ros_environment(e.g. when using the Nix package manager):This commit adds dependency on
ros_environmentto packages where it is needed.