Introduced password input widget

[jetchirag]

Description

Added a new PasswordInput widget for PyQt to improve functionality and reusability.

Not completed and looking for feedback.

Related Issue

I was thinking that we could use a common widget (a self-implemented one) for all password entries in vorta. Can you implement such thing?

Originally posted by @real-yfprojects in #1659 (comment)

Screenshots (if appropriate):

visiblity toggle:

validation error (min length):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read the CONTRIBUTING guide.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

[jetchirag]

UI is mostly the same.

[real-yfprojects]

Nice. Maybe we can reduce duplicated code even more by having a widget that unifies the two password lineEdits and the related labels. This would involve these steps:

• Rename PasswordInput to something like PassswordLineEdit
• Make it subclass QLineEdit
• Add and implement a password input class consisting of two PasswordLineEdits
• Move all validation logic/rules into the new class
• Use it in existing ui layouts

[jetchirag]

Add and implement a password input class consisting of two PasswordLineEdits

So a QWidget? What do you think about a link_with parameter in same class to link confirm input with first one? We can still move validation to this class and use features of QLineEdit too.

[real-yfprojects]

So a QWidget?

For the one containing multiple Widgets yes.

What do you think about a link_with parameter in same class to link confirm input with first one? We can still move validation to this class and use features of QLineEdit too.

Together with the min password length this spreads password validation rules over multiple places and classes.

[jetchirag]

Can you please take a look at the use of translation?

[real-yfprojects]

This is looking like what I had in mind. How Vorta uses the password inputs makes it hard to move it into its own class. Although inheriting QWdiget would be nice, it doesn't make much sense for this use. I think inheriting QObject would be better. This makes PasswordInput a manager of widgets instead of a widget itself.

[m3nu]

Hey, thanks for removing some duplicate code here. Just tried it locally and noticed this:

• The first time someone reveals the password, the icon doesn't match the state. (Icon and tooltip says "Show password", but password is already shown)
• For the case of Existing Repo, the spacing at the bottom could be more consistent with the New Repo case.

[jetchirag]

Fixed in new commits. Also resolved merge conflicts.

[m3nu]

The show/hide icon state works as expected now.

Just for the "Add Existing Repo" dialog, there may be a fixed height set, which squeezes the lines a bit. I know we wanted to reduce the extra space a bit, but this needs to be done without settings a fixed height on the dialog window, but by editing the ?vertical space element within it. (I know Qt can be fickle).

[jetchirag]

Ah, it doesn't happen on OS and UI I'm testing on. I'll fix that.

[jetchirag]

@m3nu Without changing fixed height, do you want to expand the inner widget?

I enabled verstretch for this.

[m3nu]

The lines are fine now, but the "Add existing" dialog is too high. Seems to have the same height, but one fewer row of inputs.

Would be good to make make the inner widget flexible height too? Currently the "Add Existing" dialog looks somewhat unfinished with this extra space.

[jetchirag]

Sorry I'm still unsure what you are proposing. I don't think inner widget has a fixed height but because main layout has fixed height, it's expanding. The fixed height seems to be based on Add new repo so can we use a lower fixed height for this dialog?

92608f9#diff-804dae53d409307e28853c1c80251c625c13f04bd7b0037ef30dc99fe347a77dR10

[real-yfprojects]

If possible we shouldn't use fixed heights when creating a GUI.

[jetchirag]

Okay so I've removed the fixed size property and added some margin. I've also set a min width otherwise existing repo dialog would be quite smaller than the new repo dialog. Let me know if I understood it correctly.

[real-yfprojects]

Sounds good, I'll test it when I find the time.

[m3nu]

Looks good on macOS 👍

[real-yfprojects]

Very nice! One slight problem though:

This only happens when the border colour is altered.

[jetchirag]

Ah, fixing it.

[jetchirag]

Fixed the red border. Is that white text an issue with this widget or the theme?

[real-yfprojects]

Fixed the red border. Is that white text an issue with this widget or the theme?

Both is fixed now. On my desktop the text is white and the background black.