xxh3 cleanup #44
Merged
xxh3 cleanup #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmazakas
force-pushed
the
feature/xxh3-cleanup
branch
from
992ce13 to
de0be1b
Compare
pdimov
reviewed
May 8, 2025
include/boost/hash2/xxh3.hpp
Outdated
| BOOST_CXX14_CONSTEXPR xxh3_128( std::uint64_t seed, unsigned char const* p, std::size_t n, bool with_secret ): seed_( seed ) | ||
| { | ||
| with_secret_ = true; | ||
| with_secret_ = with_secret; |
Member
There was a problem hiding this comment.
I suppose this can now go in the member initializer list, for aesthetic reasons if nothing else.
cmazakas
force-pushed
the
feature/xxh3-cleanup
branch
from
de0be1b to
fef82ef
Compare
cmazakas
force-pushed
the
feature/xxh3-cleanup
branch
from
fef82ef to
e8abd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.