-
Notifications
You must be signed in to change notification settings - Fork 229
Null pointer when reindexing edge list #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would it be relatively easy to add a test-case that fails without this fix? |
|
I added a test case. Also added it to the Jamfile.v2. Not used to this test system, so please verify I did it in the right way. |
|
I'm helping out with the PR backlog. Looks like you have a bugfix, test, and no new examples will be needed. This will be in the first batch of merged PR's. This is to let you know and help me prioritize PR's. |
|
Your test file was not included in the test directory. Make sure you added it to git. |
|
I see what happened. The test you added has a different file name than the test file you added. I'll just fix that up. |
|
Missed that you wrote that you had fixed it yourself. Not super important, but the name "delete edge" is a bit misleading, it's actually a vertex that is being deleted in the test. Sorry about that. Thanks! |
|
Are these changes in #114? If so this can be closed now. |
|
These changes are in #114 and so this should be closed. |
Don't copy value_type if not needed, as source's m_property will be set to null when copied.
See https://svn.boost.org/trac10/ticket/13544.