Skip to content

Conversation

@raahlb
Copy link

@raahlb raahlb commented Jul 30, 2018

Don't copy value_type if not needed, as source's m_property will be set to null when copied.

See https://svn.boost.org/trac10/ticket/13544.

@jeremy-murphy
Copy link
Contributor

Would it be relatively easy to add a test-case that fails without this fix?

@raahlb
Copy link
Author

raahlb commented Aug 23, 2018

I added a test case. Also added it to the Jamfile.v2. Not used to this test system, so please verify I did it in the right way.

@anadon
Copy link
Contributor

anadon commented Aug 31, 2018

I'm helping out with the PR backlog. Looks like you have a bugfix, test, and no new examples will be needed. This will be in the first batch of merged PR's. This is to let you know and help me prioritize PR's.

@anadon
Copy link
Contributor

anadon commented Sep 1, 2018

Your test file was not included in the test directory. Make sure you added it to git.

@anadon
Copy link
Contributor

anadon commented Sep 1, 2018

I see what happened. The test you added has a different file name than the test file you added. I'll just fix that up.

@raahlb
Copy link
Author

raahlb commented Sep 2, 2018

Missed that you wrote that you had fixed it yourself. Not super important, but the name "delete edge" is a bit misleading, it's actually a vertex that is being deleted in the test. Sorry about that.

Thanks!

@jzmaddock
Copy link
Contributor

Are these changes in #114? If so this can be closed now.

@anadon
Copy link
Contributor

anadon commented Oct 12, 2018

These changes are in #114 and so this should be closed.

@raahlb raahlb closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants