Skip to content

Updated and removed deprecated packages related to graphql subscriptions#1482

Open
javiertoledo wants to merge 3 commits intomainfrom
upgrade/graphql-ws
Open

Updated and removed deprecated packages related to graphql subscriptions#1482
javiertoledo wants to merge 3 commits intomainfrom
upgrade/graphql-ws

Conversation

@javiertoledo
Copy link
Member

Description

Closes issue #1476

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@sweep-ai-deprecated
Copy link
Contributor

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Do not include large chunks of commented-out code.
  • Apply: Ensure that error logs use traceback during exceptions.
  • Apply: Remove debug logs and print statements from production code.
  • Apply: All the business logic in the 'src' folder for each package should have the corresponding unit tests in the 'test' folder in the same package.
  • Apply: Avoid 'any' types when possible.
  • Apply: If there's a simpler way to express a type, it should be used.

@ghost
Copy link

ghost commented Oct 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@javiertoledo javiertoledo changed the base branch from main to v2.x.x October 25, 2023 21:32
@javiertoledo
Copy link
Member Author

/integration sha=8c87d4be4a51500591678c3d1c5573e623725ef5

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@javiertoledo
Copy link
Member Author

/integration sha=4a7132ad7a0d46545b5036108e529bb838285158

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

Base automatically changed from v2.x.x to main November 1, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Drop the deprecated dependency graphql-transport-ws in favor of graphql-ws

1 participant