Conversation
swalke16
commented
Jun 18, 2025
| fail-fast: false | ||
| matrix: | ||
| # Due to https://github.com/actions/runner/issues/849, we should quote versions | ||
| ruby: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0', 'truffleruby-head'] |
Author
There was a problem hiding this comment.
We don't care about these ruby / rails version for our purposes, remove to save build time and resources.
jibarra
approved these changes
Jun 18, 2025
jibarra
left a comment
jibarra
left a comment
There was a problem hiding this comment.
Looks fine to me. I'm guessing the real testing will come when we try to bump this gem's version in special sauce.
Comment on lines
+41
to
+54
| appraise "rails-7.1" do | ||
| gem 'railties', '~> 7.1' | ||
| gem 'activesupport', '~> 7.1' | ||
| end | ||
|
|
||
| appraise "rails-7.2" do | ||
| gem 'railties', '~> 7.2' | ||
| gem 'activesupport', '~> 7.2' | ||
| end | ||
|
|
||
| appraise "rails-8.0" do | ||
| gem 'railties', '~> 8.0' | ||
| gem 'activesupport', '~> 8.0' | ||
| end No newline at end of file |
Author
There was a problem hiding this comment.
Yep, I hadn't seen this before but it's actually pretty cool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to upgrade our Rails version past 7.0 we need to upgrade the version of Rails that this gem supports. I did not attempt to bring this fork up-to-date with the main because:
We don't need any new functionality from the gem.
The ugprades made since we worked were pretty much all about replacing attr_encyrpted and use of their own cipher key with things built into Rails 7+ and our fork removed all of that stuff as it didn't work with Mongoid anyway. 🤷♂️
Really we should probably just either home roll this entirely ourselves or use a different solution.
This also adds devbox to the gem to make it easy to work against in our environment which pushes it further away from the primary.
Testing Notes:
I was able to verify this still works by setting up MFA locally and logging in with it.