Skip to content

Fix vulkan validation#187

Open
qbojj wants to merge 3 commits intobombomby:masterfrom
qbojj:fix-vulkan
Open

Fix vulkan validation#187
qbojj wants to merge 3 commits intobombomby:masterfrom
qbojj:fix-vulkan

Conversation

@qbojj
Copy link
Contributor

@qbojj qbojj commented Dec 21, 2022

Fixing #186 and #124.

@qbojj
Copy link
Contributor Author

qbojj commented Dec 22, 2022

It also changes wait operation form VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT to VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT (there could be compute or transfer workloads)

@qbojj
Copy link
Contributor Author

qbojj commented Dec 22, 2022

I do not know if it works on MacOS. Needs checking.

@qbojj qbojj marked this pull request as ready for review December 27, 2022 15:31
@qbojj
Copy link
Contributor Author

qbojj commented Dec 27, 2022

Note that it still doesn't check if there are more than 1024 GPU events per frame so if such situation occurs it introduces undefined behaviour for whole program.

@qbojj qbojj changed the title Fix vulkan Fix vulkan validation Jan 4, 2023
Supercomet added a commit to Supercomet/OO_VULKAN that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant