Enable strict type checking across Wiring layer #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolshakov
force-pushed
the
feature/strict-type-checking
branch
3 times, most recently
from
e54d438 to
5616139
Compare
bolshakov
changed the title
Remove Steep ignores for core Wiring components, bringing them under strict type checking. Previously only Domain and Infrastructure layers were fully typed. Replaced `**settings` hash splats with explicit keyword parameters throughout the public API. Hash splats defeat static analysis since Steep can't infer which keys are valid. Required to type optional parameters that accept `nil` as a valid value. Without this, we can't distinguish "user passed nil" from "user passed nothing": ```ruby def light(name, threshold: T.undefined, window_size: T.undefined) ``` Internal representation for Settings that preserves the configured/unconfigured distinction through the configuration pipeline. Enables typed traversal from user input to resolved Config. Replaces ad-hoc `Hash[Symbol, untyped]` with a typed container that Steep can reason about. - `ConfigNormalizer` - logic moved into `ConfigurationPipeline` - Hash-based settings passing throughout factory classes
bolshakov
force-pushed
the
feature/strict-type-checking
branch
from
5616139 to
6ed0f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Steep ignores for core Wiring components, bringing them under
strict type checking. Previously only Domain and Infrastructure layers
were fully typed.
Replaced
**settingshash splats with explicit keyword parameters throughoutthe public API. Hash splats defeat static analysis since Steep can't infer
which keys are valid.
Required to type optional parameters that accept
nilas a valid value.Without this, we can't distinguish "user passed nil" from "user passed nothing":
Internal representation for Settings that preserves the configured/unconfigured
distinction through the configuration pipeline. Enables typed traversal from
user input to resolved Config.
Replaces ad-hoc
Hash[Symbol, untyped]with a typed container that Steepcan reason about.
ConfigNormalizer- logic moved intoConfigurationPipeline