Merged
Conversation
Collaborator
|
Could we have a test that verifies that the returned order is correct? |
bohning
approved these changes
Feb 8, 2026
randompersona1
approved these changes
Feb 8, 2026
| def index(self) -> int: | ||
| return _ColumnRegistry.columns.index(self) | ||
|
|
||
| def val(self) -> ColumnValue: |
Collaborator
There was a problem hiding this comment.
Nitpick, but is there a reason to abbreviate here instead of writing value?
Collaborator
Author
There was a problem hiding this comment.
Yes, value is already taken by Enum.value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #537.
I also fixed default widths not being applied after a new column was added. Unfortunately, there is no easy way to keep the header state in this case. It would seem the only solution is implementing state persistence ourselves.
Unrelatedly, I noticed scrolling the song list got a bit choppy. Profiling revealed a lot of time was spent looking up settings and checking file paths. Should run a bit smoother now.