Login page update #102
Open
Login page update #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ifoster01
commented
Apr 26, 2023
ifoster01
commented
doesn't work yet and I'm just trying to get it to work on my local computer before using our actual backend
…into Login-Page-Update
Removing the server until it works in react then readding it.
Login finally works and successfully fetches user data when you click the button (prints in the console)! Still need to change the oauth user to be our real github and to change the redirect paths and store user data on backend but it works finally
…into Login-Page-Update
Fixed up some of the CSS as well as added a button that displays the username. Would like to automatically display username upon login but can change that later. Also added comments.
Still want to clean up the way the url link to the user's github looks but that can be done in the future.
Added more comments, made the github user account open in a new tab and made some CSS changes.
Collaborator
Author
|
Still need to implement into our backend and save user data/create user account on dynamoDB but the login process works. Also currently storing github accesstoken on localStorage (allows user to refresh page and still be login in but is not super secure) so might want to change that in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.