Skip to content

display the node when the cycle only contain one node #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fzhcary wants to merge 1 commit into
base: master
Choose a base branch
from
Open

display the node when the cycle only contain one node #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycycle/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def cli(ctx, verbose=False, help=False, source=None, here=False, ignore='', enco

if check_if_cycles_exist(root_node):
click.echo(crayons.red('Cycle Found :('))
click.echo(crayons.red(get_cycle_path(root_node)))
click.echo(crayons.red(get_cycle_path(root_node, verbose=verbose)))
click.echo(crayons.green("Finished."))
sys.exit(1)
else:
Expand Down
9 changes: 7 additions & 2 deletions pycycle/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,10 @@ def format_path(path):
:param path:
:return: str
"""
if len(path) > 1:
if len(path) == 1:
# print the node path if it recursively import itself
return str(path[0].full_path)
elif len(path) > 1:
result = [crayons.yellow(path[0].name)]

previous = path[0]
Expand All @@ -231,8 +234,10 @@ def format_path(path):
return ''


def get_cycle_path(root, acc=[], seen=set()):
def get_cycle_path(root, acc=[], seen=set(), verbose=False):
for item in root:
if verbose:
click.echo(crayons.yellow('Checking root: {} item: {}'.format(root.name, item.full_path)))
if item.full_path in seen:
return format_path(acc)
seen.add(item.full_path)
Expand Down